Skip to content

ls: follow symlinks for xattrs, fix #8216#8217

Merged
sylvestre merged 7 commits intouutils:mainfrom
sudhackar:ls-fix
Jun 19, 2025
Merged

ls: follow symlinks for xattrs, fix #8216#8217
sylvestre merged 7 commits intouutils:mainfrom
sudhackar:ls-fix

Conversation

@sudhackar
Copy link
Contributor

@sudhackar sudhackar commented Jun 18, 2025 

$ strace -e llistxattr,listxattr,getxattr ./target/debug/coreutils ls -lLd l
listxattr("l", 0x1, 0)                  = 24
listxattr("l", "system.posix_acl_access\0", 24) = 24
drwxrwxr-x+ 2 sudhackar sudhackar 4096 Jun 18 16:47 l
+++ exited with 0 +++

as compared to no +

@sudhackar
ls: follow symlinks for xattrs
d5450d7 
Signed-off-by: Sudhakar Verma <sudhakar.verma@canonical.com>
@sudhackar
Copy link
Contributor Author

sudhackar commented Jun 18, 2025

This should fix #8216

sudhackar added 2 commits June 18, 2025 18:55
@sudhackar
ls: clippy, fix ref
3175a33 
Signed-off-by: Sudhakar Verma <sudhakar.verma@canonical.com>
@sudhackar
ls: tests, fix spell
bae7a49 
Signed-off-by: Sudhakar Verma <sudhakar.verma@canonical.com>
@cakebaker cakebaker linked an issue Jun 18, 2025 that may be closed by this pull request
ls: doesn't list acl "+" status for symlinks #8216
Closed
@github-actions
Copy link

github-actions bot commented Jun 18, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

cakebaker
cakebaker reviewed Jun 18, 2025
View reviewed changes
sudhackar added 3 commits June 19, 2025 10:15
@sudhackar
ls: tests, fix path
3d9e6a1 
Signed-off-by: Sudhakar Verma <sudhakar.verma@canonical.com>
@sudhackar
ls: tests, fix regex for MinRustV
b337509 
Signed-off-by: Sudhakar Verma <sudhakar.verma@canonical.com>
@sudhackar
ls: gnu tests, use listxattr instead of llistxattr
5edc3ae 
Signed-off-by: Sudhakar Verma <sudhakar.verma@canonical.com>
@sudhackar
Copy link
Contributor Author

sudhackar commented Jun 19, 2025

I have fixed the patch for the GNU test - that passes now instead of SKIP

@sudhackar
ls: gnu tests, fix spell
bf48ee7 
Signed-off-by: Sudhakar Verma <sudhakar.verma@canonical.com>
@github-actions
Copy link

github-actions bot commented Jun 19, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sudhackar
Copy link
Contributor Author

sudhackar commented Jun 19, 2025

tests/misc/tee seems flaky locally - failed 1 out of 10 runs for me

@sylvestre
Copy link
Contributor

sylvestre commented Jun 19, 2025

we know, just ignore it :)

@sylvestre
Copy link
Contributor

sylvestre commented Jun 19, 2025

(but don't hesitate to have a look to fix it if you can reproduce it easily :)

@sylvestre sylvestre merged commit c674cf1 into uutils:main Jun 19, 2025
75 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Sep 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ls: doesn't list acl "+" status for symlinks

3 participants

@sudhackar @sylvestre @cakebaker